Should a const static variable be initialized in a c++ header file?

Question

my_test.h

#ifndef MY_TEST  
#define MY_TEST

struct obj {
  int x;
  int y;
};

class A {
private:
  const static int a=100;
  const static obj b;
};

const obj A::b={1,2};

#endif

When compiling cpp using this header file, an error 'multiple definition of 'A::b' occurs.

1. why is this when I have been using guard macro already?
2. why does A::a not produce the erro? (I can't write code const static obj b={1,2} in class A)

Answer 1

why is this when I have been using guard macro already?

Header guards only prevent the inclusion of the header file contents more than once in the same translation unit not across multiple translation units.

why is A::a does not have the error message (I can't write code const static obj b={1,2} in class A)

In-class initialization is allowed by the compiler as a special case for static data members of const literal type. Your example one is In-class initialization.

const A::b defines the same symbol name in each translation unit where the header gets included and hence breaks the one definition rule.

You need to move the definition to one and only one source cpp file so that it gets defined only once.

Answer 2

Alok has already answered your question, but here are a few simple rules of thumb, in easy-to-memorize form:

1. Declarations go in the .h file
2. Definitions go in the .cpp file

Therefore, static members need to be declared in the .h file, and then defined in the .cpp file. In your case, fix the syntax for the declarations and then move them to "my_test.cpp" file.

Answer 3

The problem is your definition of A::b doesn't contain a type. To be a valid definition, it should be:

const obj A::b = {1, 2};

This will get rid of the compilation error, but you'll still get linker errors if you include this header in more than one source file, because A::b will be multiply defined then. You should move the definition into a .cpp file.

Answer 4

Regardless of whether you have a header guard or not, placing that initialisation in a header file will mean you'll get an instance of A::b in every source file that includes that header file. Hence the linker error.

So, generally speaking, it's possible, but not a good idea.