Etiquette of GitHub Contributing, Pull Requests vs New Issue [closed]

梦想的初衷 提交于 2019-12-06 18:27:51

问题


I was wondering what the proper etiquette to contributing on GitHub is?

Should you submit a "New Issue" first and discuss the problem?

Or do you take some initiative, code, then do a "Pull Request" and discuss the code further there?

My concern with creating a "New Issue" first is that if you do a "Pull Request" after, there would be two issues #'s created... seems like a waste.

Thanks!


回答1:


The difference is quite clear:

  • if you don't think you can contribute back a patch, open a new issue (following the same kind of checklist than the one described here).
  • if you think you can make some patch to fix the issue, fork the repo, and make a pull request (once you have pushed your patch back to your fork).

If you make a pull issue first, and then create a pull request, nothing stops you to reference the issue URL in your pull request comment, in order to avoid writing again the context of your patch.



来源:https://stackoverflow.com/questions/9563881/etiquette-of-github-contributing-pull-requests-vs-new-issue

易学教程内所有资源均来自网络或用户发布的内容,如有违反法律规定的内容欢迎反馈
该文章没有解决你所遇到的问题?点击提问,说说你的问题,让更多的人一起探讨吧!