pmd

I would like my eclipse PMD plugin configuration to access the same standard ruleset files as the maven-pmd-plugin . You can configure the maven pmd plugin to use a custom set of rule sets like this: <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-pmd-plugin</artifactId> <version>2.5</version> <configuration> <rulesets> <!-- Two rule sets that come bundled with PMD --> <ruleset>/rulesets/braces.xml</ruleset> <ruleset>/rulesets/naming.xml</ruleset> <!-- Custom local file system rule set --> <ruleset>d:\rulesets\strings.xml</ruleset> <!-- Custom remote rule set accessed

In our project for chained if/else/if we would like to have following formatting: if (flag1) { // Do something 1 } else if (flag2) { // Do something 2 } else if (flag3) { // Do something 3 } And forbid following one: if (flag1) { // Do something 1 } else { if (flag2) { // Do something 2 } else { if (flag3) { // Do something 3 } } } Is there some predefined rule in either of listed above static code analysis tools to force this code style? If no - I know there is an ability to write custom rules in all of those tools, which one would you suggest to implement such a rule (not really familiar

I recently stumpled upon the following warning using PMD (embedded in hudson), my code seems to suffer CollapsibleIfStatements , which I do not fully understand. The code looks like this // list to be filled with unique Somethingness List list = new ArrayList(); // fill list for (SomeObject obj : getSomeObjects()) { // interating if (!obj.getSomething().isEmpty()) { // check if "Something" is empty * if (!list.contains(obj.getSomething())) { // check if "Something" is already in my list ** list.add(obj.getSomething()); // add "Something" to my list } } } In my opinion this code isn't more

We are using the source code analyzer PMD in our Java project. I am trying to resolve the reported issues and I am currently struggling with the GodClass rule. I know that the idea is not to create huge classes. However, I don't like the word "huge" because it's too vague. Can anybody explain how the metrics of this rule works? The report says e.g. Possible God class (WMC=47, ATFD=11, TCC=0.06315789473684211) What do all these numbers mean? Does anybody know the formula that decides whether a particular class is huge or not? Javadoc to this rule states The rule uses the detection strategy

According to the tool PMD, the following is a bad practice: String s = "" + 123; // bad String t = Integer.toString(456); // ok This is an inefficient way to convert any type to a `String`. Why is it a bad thing to do? String s = "" + 123; // bad String t = Integer.toString(456); Will be compiled to: String s = "123"; String t = Integer.toString(456); so: "" +123 is obvious slightly better! Checked with JAD public static void main(String args[]) { // 0 0:ldc1 #16 <String "123"> // 1 2:astore_1 // 2 3:sipush 456 // 3 6:invokestatic #18 <Method String Integer.toString(int)> // 4 9:astore_2 // 5

Maybe it's just me, but I can't find information which is the highest priority in PMD : 1 or 5 ? Because of http://pmd.sourceforge.net/running.html and the mention of the command line parameter -minimumpriority I think 5 is the highest and 1 is the lowest value. Am I right? lschin Actually 1 is highest priority and 5 is lowest priority. You can check the exported rule set, where <rule ref="rulesets/imports.xml/ImportFromSamePackage"/> <!-- Default --> <rule ref="rulesets/imports.xml/TooManyStaticImports"> <priority>5</priority> <!-- Change to priority [information] --> </rule> The all default

I'm on creating a maven based java project, which contains the PMD maven plugin. I use my own rule set XML and it works like a charm, except two rule sets: the emptycode and the unnecessary : when I run the build, maven says: " can't find resource ". The role definitions look like: <role ref="rulesets/emptycode" /> and <role ref="rulesets/unnecessary" /> In every other cases, this kind of definition works. What I found out is that: there is a rule set with the name " unnecessary " under ecmasrcipt category, so maybe this definition needs some suggestion to use java version. I tried multiple