Why does R# tell me, “Not all code paths return a value” in a click handler?

问题

At the end of my submit button click handler, Resharper warns that, "Not all code paths return a value."

What value would it be expecting from an event handler?

In deference to full disclosure, this is that event handler:

   $("#submit_button").click(function() {
        // http://stackoverflow.com/questions/18192288/how-can-i-compare-date-time-values-using-the-jqueryui-datepicker-and-html5-time
        var begD = $.datepicker.parseDate('mm/dd/yy', $('#BeginDate').val());
        var endD = $.datepicker.parseDate('mm/dd/yy', $('#EndDate').val());
        if (begD > endD) {
            alert('Begin date must be before End date');
            $('#BeginDate').focus();
            return false;
        }
        else if (begD.toString() == endD.toString()) {
            var dteString = begD.getFullYear() + "/" + (begD.getMonth() + 1) + "/" + begD.getDate();
            var begT = new Date(dteString + " " + $('#BeginTime').val());
            var endT = new Date(dteString + " " + $('#EndTime').val());

            if (begT > endT) {
                alert('Begin date must be before End date');
                $('#BeginTime').focus();
                return false;
            }
        }

        $("#NumberOfResults").css("visibility", "visible");
        $("#NumberOfResults").html("Please wait...");

        EnableButton("submit_button", false);

        // If all are selected, don't enumerate them; just set it at "All" (change of case shows that the logic did execute)
        var deptsList = $('#depts').checkedBoxes();
        if (deptsList.length < deptsArray.length) {
            $('#deptHeader span').html(deptsList.join(", "));
        }
        else if (deptsList.length == deptsArray.length) {
            $('#deptHeader span').html("All");
        }
        // " "
        var sitesList = $('#sites').checkedBoxes();
        $('#sitesHeader span').html(sitesList.join(", "));
        if (sitesList.length < sitesArray.length) {
            $('#sitesHeader span').html(sitesList.join(", "));
        }
        else if (sitesList.length == sitesArray.length) {
            $('#sitesHeader span').html("All");
        }

        $('#hiddenDepts').val(deptsList);
        $('#hiddenSites').val(sitesList);
        var UPCs = $('#UPC').val();
        if (UPCs == "All") {
            $('#UPC').val("1"); // take everything (1 and greater)
        }

        var resultsText = jQuery.trim($("#spanNumberOfResults").text());
        if (resultsText != "") {
            $("#NumberOfResults").css("visibility", "visible");

            if (resultsText == "0") {
                $("#NumberOfResults").css("color", "red");
            } else {
                var href = '/@ConfigurationManager.AppSettings["ThisApp"]/CCRCriteria/LoadReport';
                // report_parms (sic) is referenced from LoadReport
                var report_parms = {
                    GUID: "@Model.GUID",
                    SerialNumber: "@Model.SerialNumber",
                    ReportName: "@Model.ReportName"
                };
                window.open(href, "report_window", "resizable=1, width=850, left=" + (screen.width / 2 - 425));
            }
        }
    }); // end of submit button click

回答1:

Resharper isn't aware of event handlers.

It sees that your function will sometimes return false and sometimes won't return anything, and it complains.

It doesn't realize that this pattern is perfectly fine for event handlers.

回答2:

Ignore it. Click handlers "can" return a boolean value indicating whether to process the click normally (true) or ignore it (false).

Resharper sees any return in the function as a clue that it should always return something.

来源：https://stackoverflow.com/questions/18256969/why-does-r-tell-me-not-all-code-paths-return-a-value-in-a-click-handler

标签

onclick

resharper

jquery