PHP - Saving Uploaded Image to Server

Question

I am trying to save an uploaded image from an iPhone to a server using PHP. I am using ASIHTTPRequest to handle the data request. This is my iPhone code:

[request setPostValue:someString forKey:@"string1"];
[request setPostValue:anotherString forKey:@"string2"];
[request addData:[NSData dataWithData:UIImageJPEGRepresentation(anImage, 0.9)]
         withFileName:@"img.jpg" andContentType:@"image/jpeg" forKey:@"img"];

[request startSynchronous];

On the server side, I am using this PHP code currently to try saving the image to a folder on my server:

print_r($_FILES);

$folder = 'upload/';
$image_path = basename($_FILES['img']['name']);
echo $folder . $image_path . "\n";
if (move_uploaded_file($_FILES['img']['tmp_name'], $folder . $image_path)) {
    echo 'ok!';
} 
else {
    echo 'fail !';
}

The strings are uploaded just fine and when I print_r() i see the contents of the image array as I expect, but for some reason when trying to save the image, i am getting "fail !" printed to the console. What is wrong here?

Thanks.

Answer 1

Try the following step before you move your image

if(!is_dir($folder))
{
   echo "Folder does not exist" ;

   if(!mkdir($folder))
   {
      echo "Attempt to create folder failed" ;
   }
}
else if(!is_writable($folder))
{
   echo "Folder nto writeable" ;

   if(!chmod($folder, 0755))
   {
        echo "Attempt to make writeable failed" ;
   }
}
 else {

   if (move_uploaded_file($_FILES['img']['tmp_name'], $folder . $image_path)) {
      echo 'ok!';
   }
   else {
    echo 'fail !';
   }    
}

What do you get ???

Answer 2

Please also remember to do security checks on the file being uploaded. For example, check the file types against a whitelist (jpeg, png, gif, etc)- I'm sure you don't want someone being able to upload a script to your website?

Also for the long term you would be better off manually creating the upload folder and setting the appropriate permissions as oppose to having the PHP script do it for you..