How to resume review process after updating pull request at GitHub?

倖福魔咒の 提交于 2019-12-03 22:56:04

2 years and a half years later, (February 2019), do check if the new button "Re-request review" would help.

As illustrated on twitter, if your PR was already reviewed, but now it’s time for round 2: With fresh eyes and fresh code, re-request a review 🔃


Note/caveat: (from "Requesting a pull request review")

Pull request authors can't request reviews unless they are either a repository owner or collaborator with write access to the repository.

As noted in the comments by gertvdijk:

I am a contributor on the project and the owner of the PR.
It does not make sense to me that I need to be a collaborator on the project to request a re-review?

Oh, wow, it's by design that PR authors can't use this feature?
Damn, that's very much killing the whole feature.

The reviewer gets removed from the actual list (even though he is listed there with a cross), he does not even see the pull request in his tasks anymore. Just add him as a reviewer again.

No, there is no way you can intimate user about it.

You can comment that you have made changes - this comment will give him a notification.

Other than that, if possible, notify him via some other medium.

I agree with @prabodhprakash, use the Gear next to "Reviewers" to reselect the reviewer. This changes his status from the red 'x' back to the orange circle.

The problem is the status of the PR remains as "Changes requested". There should be a state after this such as "Changes resolved" or "Needs review" again that is initiated by the requestor, via a button, when s/he is ready for the PR to be looked at again. Otherwise, the PR still looks like it's in the already-reviewed-and-rejected" state.

I think you just wait if the reviewer is watching the issue or write a comment that you did the requested change (I would do the latter). Then the reviewer can have another look and approve the PR.

The solution is to dismiss the review. You can confidently do this because the original conversation will still be present, and you'll be asked for a comment for you to explain why you're doing this.

In a nutshell, look for the drop-down arrow next to the "1 change requested". From there you'll be able to "re-request review", but note that this alone won't change the state. In addition, or instead, you'll have to choose "dismiss review" and enter a comment, such as "made the requested changes". After you confirm, your pull request should show again as "review required" on the list of PRs, so the ball will no longer be in your court.

易学教程内所有资源均来自网络或用户发布的内容,如有违反法律规定的内容欢迎反馈
该文章没有解决你所遇到的问题?点击提问,说说你的问题,让更多的人一起探讨吧!