Why does this do-while loop not produce the right output?

Question

public static void main(String[] args) throws IOException {

    System.out.println("Hello, come and play a game with me!");

    int x = 5;
    int guess;

    do {
        System.out.println("Please input a number...");
        guess = System.in.read();
        guess = System.in.read();
        if (guess < 5) {
            System.out.println("You guessed the number!");
            break;
        }
    } while (guess > 5);
}

So here I wrote some code. It's supposed to be a guessing game, but no matter what I input, it always gives me in the output "Please input a number..." NO MATTER WHAT I PUT. Basically, if the "guess" is more than 5, then they guessed the number. If it's not, then they haven't guessed the number. That's the premise of the game. Can someone help me fix my code, so it doesn't just output the same thing regardless?

Answer 1

System.in.read(); gives you char. so when you enter "1", it gives you its char value, 49. so you can not enter integer 5 with typing numbers. so change your reading method. you can use Scanner

Answer 2

You are doing the opposite - an answer less than 5 is accepted as correct.

Answer 3

Here is a working version of your code.

As mentioned in previous answers, the System.in reads in characters so you cannot read in numbers directly. Below The code is leveraging the BufferedReader API whitch works on an InputStream.

public class App {


        public static void main(String[] args) throws IOException {

                System.out.println("Hello, come and play a game with me!");

                int x = 5;
                int guess;

                do                
                {               
                    System.out.println("Please input a number...");
                   BufferedReader br = new BufferedReader(new InputStreamReader(System.in));

                   guess = Integer.parseInt(br.readLine());
                    if(guess < 5){

                        System.out.println("You guessed the number!");                    
                        break;                    
                    }

                } while(guess>5);        
         }    
    }

Answer 4

it looks like you did not use the variable x, try using the Scanner class to get input from the user

public static void main(String[] args) throws IOException {

System.out.println("Hello, come and play a game with me!");
 int guess;
 Scanner input = new Scanner(System.in);



do {
    System.out.println("Please input a number...");
     guess = input.nextInt();
           if (guess < 5) {
        System.out.println("You guessed the number!");
        break;
    }
} while (guess > 5);

}