Setting event handlers using a for loop [duplicate]

Answer 1

i will not contain the "current index" like you are intending, but rather the last value i was, ie arr.length

One quick n dirty solution would be to do something like this

for(var i = 0; i < arr.length; i++) {
    (function(_i){
        arr[_i].onclick = function() { alert(arr[_i].innerHTML); };
    })(i);
}

what this does is captures the current value of i in a new variable _i within the closure of the statement you're executing, so it'll stay around and be the value you'd expect every time your onclick handler is called.

Answer 2

You need a closure, otherwise the arr[i] executes in an alternate scope and blows up.

for(var i = 0; i < arr.length; i++) {

    arr[i].onclick = function(text) { 
        return function () {
            alert(text); 
        };
    }(arr[i].innerHTML);
}

http://jsfiddle.net/xzmMj/5/

Answer 3

This is a common error. i is a global variable that you're incrementing in the for loop. When the loop finishes, i will be equal to 4. Then in your click handler function, you're trying to display arr[i].innerHTML, which is now arr[4].innerHTML. arr[4] obviously doesn't exist, so you get an error.

For an easy fix, change alert(arr[i].innerHTML) to alert(this.innerHTML). this, in the context of the click handler function, will refer to the <TD> element.