Factory function method not updating variable

Question

I am trying to set up a factory function with a method that would update the value for a specific variable within said factory function. This seemed like a simple thing to i