I am trying to use a comparator to help sort a list of objects. I have a question about how exactly the comparator works and what it would be doing exactly in the following
On average, your sort algorithm will call complexOperation()
method about log2N times for an array of N students. If the operation is really slow, you may be better off running it once for each student. This could bring an order of magnitude improvement for an array of 1,000 students.
However, you do not have to do it explicitly: you could make complexOperation(...)
store the result for each student, and then return the cached value on subsequent requests:
private Map<Student,Integer> cache = new HashMap<Student,Integer>();
private int complexOperation(Student s) {
// See if we computed the rank of the student before
Integer res = cache.get(s);
if (res != null) {
// We did! Just return the stored result:
return res.intValue();
}
... // do the real computation here
// Save the result for future invocations
cache.put(s, result);
return result;
}
Note that in order for this approach to work, Student
class needs to implement hashCode
and equals
.
Basically, you want to compare students by comparing some values that each maps to. This is usually done by
static Comparator<Student> comparator()
{
return Comparator.comparing( Foo::complexOperation );
}
However, since the function complexOperation
is too expensive, we want to cache its results. We can have a general purpose utility method Function cache(Function)
static Comparator<Student> comparator()
{
return Comparator.comparing( cache(Foo::complexOperation) );
}
In general, it is better that the caller can supply a Map
as the cache
public static <K,V> Function<K,V> cache(Function<K,V> f, Map<K,V> cache)
{
return k->cache.computeIfAbsent(k, f);
}
We can use IdentityHashMap
as the default cache
public static <K,V> Function<K,V> cache(Function<K,V> f)
{
return cache(f, new IdentityHashMap<>());
}