why does the ledstrip stop partway and then go all the way and can I make this more efficient

Question

So I need some help reviewing and editing the code below. Is there a way to make it more efficient instead of what I did. Also are there better ways to do some o the methods