C# Hashset Contains Non-Unique Objects

Question

Using this class

public class Foo
{
    public string c1, c2;

    public Foo(string one, string two)
    {
        c1 = one;
        c2 = two;
    }

    pu         


        

Answer 1

The HashSet<T> type ultamitely uses equality to determine whether 2 objects are equal or not. In the type Foo you have only overridden GetHashCode and not equality. This means equality checks will default back to Object.Equals which uses reference equality. This explains why you see multiple items in the HashSet<Foo>.

To fix this you will need to override Equals in the Foo type.

public override bool Equals(object obj) { 
  var other = obj as Foo;
  if (other == null) {
    return false;
  }
  return c1 == other.c1 && c2 == other.c2;
}

Answer 2

You need to override the equals method as well. The reason for this is that the hashcode is allowed to collide for two objects that is not equal. Otherwise it won't work.

public override bool Equals(Object obj)
{ 
   Foo otherObject = obj as Foo;
   return otherObject != null && otherObject.c1 == this.c1 && otherObject.c2 == this.c2;
}

Answer 3

You need to override Equals method. Only GetHashCode is not enough.