Initializing a char pointer in C. Why considered dangerous? [duplicate]

Answer 1

A literal string in a C program is considered to be read-only and the compiler/linker/loader may arrange for the memory of that string to be in memory that is protected against writing.

Depending on your compiler and OS, the following may trigger a runtime error:

char *a = "test";
a[0] = 'T';

Of course, if you don't actually try to change the string data, then doing this is not dangerous per se. However, it's useful to get the compiler to assist you in ensuring this by declaring the pointer const:

const char *a = "test";

With this declaration, an attempt to a[0] = 'T' would be a compile error and would therefore be detected much sooner than runtime.

Answer 2

String literals like "test" are read-only and so they cannot be modified. So any attempt to modify them will result in undefined behavior.

For example:

char *a = "test";
*a = 'b';

The *a = 'b'; is an undefined behavior.

So if you want to modify them then you need to use an array

char a[]="test";

So you can modify the "test" to "best" by doing the following:

a[0] = 'b';

Answer 3

Exactly.

For instance the string defined by char s[] = "hello world" in C and a C statement like int debug=1 outside the "main" would be stored in initialized read-write area. And a C statement like const char* string = "hello world" makes the string literal "hello world" to be stored in initialized read-only area and the character pointer variable string in initialized read-write area. Ex: static int i = 10 will be stored in data segment and global int i = 10 will be stored in data segment

Answer 4

I have read at some places that this is considered read-only and that it's dangerous.

String literals are indeed read-only.

Does that imply that the "test" is not allocated space in the heap?

Whether the space for the string is allocated is not specified by the standard. It's usually on the static section of the program, but the standard does not even mention things as the heap.

Does that mean that the string "test" can be written over later in the program?

Writing over the string is undefined behavior.

Answer 5

All string literals are read-only even though their type may not say so. A string literal's type is char[], (for example, "Hello" is of type char[6], one extra for the '\0' character). Although it is not const-qualified, the standard says the following in §6.4.5/6:

…If the program attempts to modify such an array, the behavior is undefined.

If you want a mutable version, you have to either make a copy of the string, or declare it like so:

char a[] = "test";

Answer 6

This is dangerous because the string is not-modifiable. Attempting to do so results in undefined behavior.

So it's preferred to do:

const char *a = "test";

You are correct that "test" in this case is not allocated on the heap or the stack* and instead lies in static memory that is not-modifiable.

*The standard says nothing about the stack or heap, though that's how it's usually implemented.

On the other hand:

char a[] = "test";

Is safe to modify since it's just short-form for:

char a[] = {'t','e','s','t','\0'};

which is an ordinary modifiable array.