String tokenise split within function unexpected behaviour

Question

I am working on a project where I need to take an expression and split it into tokens.

Here is the full code so far:

#include 
#include