What is the best practice for functions that complete with fund transfers?

Question

Should the func return the transfer promise or transfer the funds async and return void?

fn withdraw_all(&mut sel