What code metric(s) convince you that provided code is “crappy”? [closed]

Answer 1

• Watch out for ratio of Pattern classes vs. standard classes. A high ratio would indicate Patternitis
• Check for magic numbers not defined as constants
• Use a pattern matching utility to detect potentially duplicated code

Answer 2

Ratio of comments that include profanity to comments that don't.

Higher = better code.

Answer 3

A lot of conversions to and from strings. Generally it's a sign that the developer isn't clear about what's going on and is merely trying random things until something works. For example, I've often seen code like this:

   object num = GetABoxedInt();
//   long myLong = (long) num;   // throws exception
   long myLong = Int64.Parse(num.ToString());

when what they really wanted was:

   long myLong = (long)(int)num;