Is it a good practice to have logger as a singleton?

Question

I had a habit to pass logger to constructor, like:

public class OrderService : IOrderService {
     public OrderService(ILogger logger) {
     }
}


        

Answer 1

I put a logger instance in my dependency injection container, which then injects the logger into the classes which need one.

Answer 2

There is a book Dependency Injection in .NET. Based on what you need you should use interception.

In this book there is a diagram helping to decide whether to use Constructor injection, property injection, method injection, Ambient Context, Interception.

That's how one reasons using this diagram:

1. Do you have dependency or need it? - Need it
2. Is it cross-cutting concern? - Yes
3. Do you need an answer from it? - No

Use Interception