Test for void pointer in C++ before deleting

Question

I have an array in C++:

Player ** playerArray;

which is initialized in the constructor of the class it is in.

In the destructor I

Answer 1

Here's how operator delete is defined.

void operator delete(void*) throw();
void operator delete[](void*) throw();

'operator delete' takes a 'void *' since a pointer to any object can be converted to 'void *'.

Note that a void is an incomplete type and hence it is not allowed to delete a void * i.e

char *p = new char;
void *pv = p;
delete pv;            // not allowed

Footnote 78: This implies that an object cannot be deleted using a pointer of type void* because void is not an object type.

In the case where playerarray is a pointer to an array of Players, you most likely want to do it differently. delete pplayer does not do what you want it to.

Answer 2

I think what valgrind is warning about is that the delete is occuring in the context of something like this:

int foo(void *mydata){
{
    SomeClass some_value = static_cast<SomeClass> mydata;
    some_value.dosomething();
    // now we're done with it
    delete mydata;
}

although the cast is fine, since you happen to know that the void pointer is actually that type, you're still doing something fishy, because you're deleting the void pointer, rather than the typed pointer. If SomeClass is POD, that's probably ok, but if it has some critical work it must do in its destructor, that destructor never gets called.

Answer 3

Perhaps you meant delete [] playerArray. You need the [] if the pointer is an array, not a single instance.