Is the tap operator appropriate here?

Question

I finally got this feature to work exactly the way I want it to, but can\'t help but feel like the use of tap is a code smell. Is there a better, or "more