How can i optimize this code? i am relatively new and want to learn further

Question

I want to learn some tricks to reduce the overall length of this piece of code i wrote. I also would like some tips on this code. Thanks.

Also how can i know how to m