Is there a way to get the open call to work properly?

Question

i working on a shell program and i need to to do redirection. i am having 2 issues. first being when i try to open the file that the user enters, it is always -1 and i dont