Why does OnClickListener on a ViewHolder don't work?

Question

I\'m trying to implement a way to handle item selection on a RecyclerView. I personally don\'t like the way suggested in some answers on SO of passing through g

Answer 1

Simplely Click Handler your ViewHolder. Recycler View don't have special attaching click handlers like ListView which has the method setOnItemClickListener().

** public class ViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener

** in public ViewHolder(Context context, View itemView) set public void onClick(View view)

** get position by: int position = getLayoutPosition(); User user = users.get(position);

Answer 2

Looking at the updated code: you are not setting the onClickListener to any of the views in the ViewHolder. It is an understandable mistake to forget the click listener.

Just use:

tvName.setOnClickListener(this);
star.setOnClickListener(this);

You can set to both or just one of them. You can also simply get the parent layout of these two views, so that the whole item itself in the adapter can be clickable.

itemView.setOnClickListener(this);

Answer 3

You can do it in your onBindViewHolder

         @Override
        public void onBindViewHolder(ReportViewHolder holder, int position {
      holder.itemView.setOnClickListener(new View.OnClickListener() {
        @Override 
        public void onClick(View arg0) { 
        // handle your click here. 
    } }); 
}