regex has no method test [closed]

Answer 1

You should call the test method on the regex instance, not on the string input:

if (r.test(pin) && (pin.length == 4 || pin.length == 6)) {

Also notice the precedence of the logical operators.