Reading data from a file and storing it into a vector

Question

I\'m trying to read a list of items from from a file and then store them into a vector. The issue is my code is adding the last item to the vector twice and I\'m not sure why th

Answer 1

The problem is that the "fail" flag is not set until you make an attempt at reading some more data from the file. Here is a quick way of fixing this:

for (;;) {
    //Extract the line from the list
    getline(inputFile,item_name,'-');
    getline(inputFile,item_unit,'-');
    inputFile >> item_amount;
    inputFile >> item_price;
    if (inputFile.fail()) break;
    //Create an instance of the item object
    Item New_Item(item_name, item_unit, item_amount,item_price);
    //Push it to the list vector
    list.push_back(New_Item);
}

If this is for a learning exercise, and you have not learn the >> operator yet, this should do it. Otherwise, the operator>> approach is better.