strtok problem in calling

Question

I have a function using strtok like this

void f1(char *name)
{
...
char *tmp;
tmp = strtok(names, \" ,\");
while(tmp)
{
...
tmp = strtok(NULL, \" ,\");
}
...
}
<         


        

Answer 1

Are you truly passing in a string literal?

f1("abc,def");

will pass a pointer to the string literal to the strtok() in f1() - since strtok() modifies the string, and a string literal can't be modified, so you'll get undefined behavior (though I would expect a crash or fault instead of unexpected results).