Type mismatch: cannot convert from void to ArrayList

Question

Why am I getting this error for this code? I have the correct imports for ArrayList an Collections

private ArrayList tips;

public TipsTask(ArrayLi         


        

Answer 1

I think you should write it like this:

private List tips;

public TipsTask(List tips) {
    this.tips = new ArrayList(tips);
    Collections.shuffle(this.tips);
}

The other way breaks making the List private. The person with the original reference can manipulate your private state.