Memory access violation. What's wrong with this seemingly simple program?

Question

This is a quick program I just wrote up to see if I even remembered how to start a c++ program from scratch. It\'s just reversing a string (in place), and looks generally c

Answer 1

When using more strict compiler settings, this code shouldn't even compile:

char* str = "Constant string";

because it should be constant:

const char* str = "Now correct";
const char str[] = "Also correct";

This allows you to catch these errors faster. Or you can just use a character array:

char str[] = "You can write to me, but don't try to write something longer!";

To be perfectly safe, just use std::string. You're using C++ after all, and raw string manipulation is extremely error-prone.