Is good to call function in other function parameter?

Question

I suppose this:

public static string abc()
{
    return \"abc\";
}

Is better to call this function in this way:

string call         


        

Answer 1

Given your exact example (one parameter, value not used elsewhere, no side effects), it's just a matter of style. However, it gets more interesting if there are multiple parameters and the methods have side effects. For example:

int counter;

int Inc() { counter += 1; return counter }

void Foo(int a, int b) { Console.WriteLine(a + " " + b); }

void Bar()
{
    Foo(Inc(), Inc());
}

What would you expect Foo to print here? Depending on the language there might not even be a predictable result. In this situation, assigning the values to a variable first should cause the compiler (depending on language) to evaluate the calls in a predictable order.