Finding end of file while reading from it

Question

void graph::fillTable()
{
  ifstream fin;
  char X;
  int slot=0;

  fin.open(\"data.txt\");

  while(fin.good()){

  fin>>Gtable[slot].Name;
  fin>>Gtab         


        

Answer 1

The file won't fail until you actually read from past the end of file. This won't occur until the fin>>Gtable[slot].Name; line. Since your check is before this, good can still return true.

One solution would be to add additional checks for failure and break out of the loop if so.

fin>>Gtable[slot].Name;
fin>>Gtable[slot].Out;
if(!fin) break;

This still does not handle formatting errors in the input file very nicely; for that you should be reading line by line as mentioned in some of the other answers.