Where am I going wrong?
I have some files as follows:
filename_tau.txt filename_xhpl.txt filename_fft.txt filename_PMB_MPI.txt filename_mpi_tile_io.txt
Set up your for loop like this. With this syntax, the loop iterates over the positional parameters, assigning each one to 'point' in turn.
for point; do grep "$str" ${filename}${point}.txt done