FindBugs - how to solve EQ_COMPARETO_USE_OBJECT_EQUALS

Question

I am clueless here...

 1: private static class ForeignKeyConstraint implements Comparable {
 2: String tableName;
 3: String fkFi         


        

Answer 1

You can solve it by implementing an equals() method. Refer to the FindBugs definition:

"Generally, the value of compareTo should return zero if and only if equals returns true. If this is violated, weird and unpredictable failures will occur in classes such as PriorityQueue."

"It is strongly recommended, but not strictly required that (x.compareTo(y)==0) == (x.equals(y))."

Another example is the TreeSet. It implements equality checks by invoking compareTo, and a compareTo implementation that is inconsistent with equals makes the TreeSet violate the contract of the Set interface, which might lead to program malfunction.