This might be a dumb question, but maybe someone can provide some insight.
I have some global variables defined in a header file (yes yes I know that\'s bad, but thi
In C, identifiers have three different types of "linkage":
static keyword.For objects with external linkage, you can have only one definition. Since your header file defines such an object and is included in two C files, it is undefined behavior (but see below). The fact that your C compiler doesn't complain does not mean it is OK to do so in C. For this, you must read the C standard. (Or, assuming no bugs in your compiler, if it is invoked in a standards-compliant mode, and if it complains about something [gives a diagnostic], it probably means your program isn't compliant.)
In other words, you can't test what is allowed by the language by testing something and checking if your compiler allows it. For this, you must read the standard.
Note that there is a subtle difference between definition and tentative definition.
$ cat a.c
int x = 0;
$ cat b.c
#include
int x = 0;
int main(void)
{
printf("%d\n", x);
return 0;
}
$ gcc -ansi -pedantic -W -Wall -c a.c
$ gcc -ansi -pedantic -W -Wall -c b.c
$ gcc -o def a.o b.o
b.o:(.bss+0x0): multiple definition of `x'
a.o:(.bss+0x0): first defined here
collect2: ld returned 1 exit status
Now, let's change a.c:
$ cat a.c
int x; /* Note missing " = 0", so tentative definition */
Now compile it:
$ gcc -ansi -pedantic -W -Wall -c a.c
$ gcc -o def a.o b.o
$ ./def
0
We can change b.c instead:
$ cat a.c
int x = 0;
$ cat b.c
#include
int x; /* tentative definition */
int main(void)
{
printf("%d\n", x);
return 0;
}
$ gcc -ansi -pedantic -W -Wall -c a.c
$ gcc -ansi -pedantic -W -Wall -c b.c
$ gcc -o def a.o b.o
$ ./def
0
A "tentative definition" becomes "real definition" in C if there is no other definition. So, we could have changed both files to contain int x;, and it would be legal C.
So, you may have a tentative definition in the header file. We need to see the actual code to be sure.
The C standard says that the following is undefined behavior (appendix J.2p1):
An identifier with external linkage is used, but in the program there does not exist exactly one external definition for the identifier, or the identifier is not used and there exist multiple external definitions for the identifier.
C++ may have different rules.
Edit: As per this thread on comp.lang.c++, C++ does not have tentative definitions. The reason being:
This avoids having different initialization rules for built-in types and user-defined types.
(The thread deals with the same question, btw.)
Now I am almost sure that OP's code contains what C calls "tentative definition" in the header file, which makes it legal in C and illegal in C++. We will know for sure only when we see the code though.
More information on "tentative definitions" and why they are needed is in this excellent post on comp.lang.c (by Chris Torek).