KeyVault GetSecretAsync never returns

Question

The sample code for working with KeyVault inside a web application has the following code in it:

public static async Task GetSecret(string secr         


        

Answer 1

Unfortunately, the call never returns and the query hangs indefinitely...

You have a classic deadlock. That's why you shouldn't block on async code. Behind the scenes, the compiler generates a state-machine and captures something called a SynchronizationContext. When you synchronously block the calling thread, the attempt to post the continuation back onto that same context causes the deadlock.

Instead of synchronously blocking with .Result, make your controller async and await on the Task returned from GetSecret:

public async IHttpActionResult FooAsync()
{
    var secret = await KeyVaultAccessor.GetSecretAsync("https://superSecretUri");
    return Ok();
}

Side note - Async methods should follow naming conventions and be postfixed with Async.