php json_encode is encoding the same data twice

Question

I am getting some data from a database and am encoding it to json:

$json = \"\";
if($result = $dbc->query($query)) {
    $num = $result->num_rows;
             


        

Answer 1

Pekka is probably right, but I would like to add that you are making more work for yourself by calling json_encode() for every row. It's probably better to build your data structure, and then call json_encode() on that:

$rows = array();
if ($result = $dbc->query($query)) {
    $num = $result->num_rows;
    for ($i = 0; $i < $num; $i++) {
        $rows[] = $result->fetch_assoc();
    }
}
$json = json_encode($rows);

Marking as community wiki as this is a suggestion on practice and not an answer.