I\'ve read this answer about eight-five times, but there\'s something I\'m not understanding correctly:
git-upload-pack: command not found, how to fix this correctly
Yes, it is to do with login and non-login shells. The .bashrc file only gets loaded in non-login shells. You can use .bash_profile for login shells. Just add the same modification to your PATH in the .bash_profile file and you should be good.
export PATH=/usr/local/bin:$PATH
You may find this is an interesting article on the difference between .bashrc and .bash_profile, and login and non-login shells.