Problem with strtok and segmentation fault

Question

I have two helper functions to break up strings in the format of decimal prices ie. \"23.00\", \"2.30\"

Consider this:

char price[4] = \"2.20\";

            


        

Answer 1

This:

char price[4] = "2.20";

leaves out the nul terminator on price. I think you want this:

char price[5] = "2.20";

or better:

char price[] = "2.20";

So, you will run off the end of the buffer the second time you try to get a token out of price. You're just getting lucky that getCents() doesn't segfault every time you run it.

And you should almost always make a copy of a string before using strtok on it (to avoid the problem that Jonathan Leffler pointed out).