WakefulIntentService implementation clarifications

Question

Commonsware\'s WakefulIntentService works beautifully but there are some things I do not quite get. Below is the core of the service - a stripped down version of the source

Answer 1

Sorry don't have enough rep to comment but it looks like you have a race condition with the two checks if(held)release and if(!held)acquire. I.e. making the ref volatile is not enough to guard you against races.

These are composite statements invoked on different threads. You likely want to enter a sync block on a private final Object lock = new Object() for those two checks so they are done atomically. Very corner-y but thought I'd mention it. Let me know if you disagree. Thanks.