Is there a performance difference between these two algorithms for shuffling an IEnumerable?

Question

These two questions give similar algorthims for shuffling an IEnumerable:

• C#: Is using Random and OrderBy a good shuffle algorithm?
• Can you enumerate

Answer 1

The first doesn't compile, although it's apparent that you're trying to reify the enumerable, and then implement Fisher-Yates; that's probably the correct approach, and it shouldn't be unclear to anyone who has ever shuffled an array before. The second using RemoveAt is bad for the reasons stated by other commenters.

EDIT: Your top implementation looks like it's correct now, and it's a good way to do it.