Complex circular dependency

Question

what is the the best practice of solving circular dependency in C++?

I could use the forward declaration, but then I get the pointer to incomplete

Answer 1

One thought is to introduce interfaces and remove the circular dependencies. So you would have an IEffect that Effect, Player, and EffectContainer depend on. Possibly, if Player depends on certain behavior of Effect and EffectContainer depends on a different set of behavior, I would consider introducing two interfaces, effectively following the Interface Segregation Principle. This would also follow along with the Dependency Inversion Principle.