Node: Generate 6 digits random number using crypto.randomBytes

Question

What is the correct way to generate exact value from 0 to 999999 randomly since 1000000 is not a power of 2?

This is my approa

Answer 1

It's a correct algorithm (https://en.wikipedia.org/wiki/Rejection_sampling), though you could consider using bitwise operations instead of converting to hex. It can run forever if the random number generator is malfunctioning -- you could consider trying a fixed number of times and then throwing an exception instead of looping forever.