An exception of type 'System.Data.SqlClient.SqlException' occurred in System.Data.dll

前端 未结 6 1214
醉梦人生
醉梦人生 2020-12-16 04:07

When I execute my code below, this error message occurs:

"An exception of type \'System.Data.SqlClient.SqlException\' occurred in System.Data.dll bu

6条回答
  •  轮回少年
    2020-12-16 04:41

    There are some problems with your code. First I advise to use parametrized queries so you avoid SQL Injection attacks and also parameter types are discovered by framework:

    var cmd = new SqlCommand("SELECT EmpName FROM Employee WHERE EmpID = @id", con);
    cmd.Parameters.AddWithValue("@id", id.Text);
    

    Second, as you are interested only in one value getting returned from the query, it is better to use ExecuteScalar:

    var name = cmd.ExecuteScalar();
    
    if (name != null)
    {
       position = name.ToString();
       Response.Write("User Registration successful");
    }
    else
    {
        Console.WriteLine("No Employee found.");
    }
    

    The last thing is to wrap SqlConnection and SqlCommand into using so any resources used by those will be disposed of:

    string position;
    
    using (SqlConnection con = new SqlConnection("server=free-pc\\FATMAH; Integrated Security=True; database=Workflow; "))
    {
      con.Open();
    
      using (var cmd = new SqlCommand("SELECT EmpName FROM Employee WHERE EmpID = @id", con))
      {
        cmd.Parameters.AddWithValue("@id", id.Text);
      
        var name = cmd.ExecuteScalar();
      
        if (name != null)
        {
           position = name.ToString();
           Response.Write("User Registration successful");
        }
        else
        {
            Console.WriteLine("No Employee found.");
        }
      }
    }
    

提交回复
热议问题