Cursor in procedure returning more values than query

Question

I am using a simple cursor in a procedure that receives a couple of parameters. I then make a cursor on a select query with a where clause with multiple conditions, which ar

Answer 1

In addition to what Alex has said (and I can't second his advice to distinguish variable names from column names enough!), why are you using a cursor for loop to do the insert?

You could just do your insert in one SQL statement, eg:

insert into your_table (col1, col2, ...)
select col1, col2, ...
from   your_table
where  ...

That will perform much better than going through the whole dataset and inserting each row one at a time. When it comes to databases, think set-based as much as you can, not procedurally!