yield returns within lock statement

前端 未结 3 1098
不知归路
不知归路 2020-12-10 10:32

if i have a yield return in a lock statement does the lock get taken out on each yield (5 times in the example below) or only once for all the items in the list?

Tha

3条回答
  •  孤街浪徒
    2020-12-10 11:19

    BEGIN EDIT
    Please refer to the code in the community wiki provided by @EZI which is easier to read / cleaner.
    END EDIT

    Sorry to resurrect this from the dead, but reading the accepted answer by Daniel, and then testing it myself I though that at least those 10 people up-voting should at least know it's completely wrong.

    The answer is: The lock is NEVER released between each yeald return.
    NOTE: It is however released when the enumerator is done, i.e. when the foreach loop ends.

    Daniel's answer is wrong in claiming that the lock is taken more than once. That is because Daniel's code is not multi-threaded, it would always compute the same way. The lock in that code is taken only once, and since it's the same thread, it's always the same lock.

    I took @Daniel's code from his answer, and changed it to work with 2 threads, one for List1 and another thread created for each iteration of List2.

    As you can see once t2 thread is started, the threads would dead-lock, since t2 is waiting on a lock that would never be released.

    The Code:

    void Main()
    {
        object locker = new object();
        IEnumerable myList0 = new DataGetter().GetData(locker, "List 0");
        IEnumerable myList1 = new DataGetter().GetData(locker, "List 1");
        IEnumerable myList2 = new DataGetter().GetData(locker, "List 2");
    
        Console.WriteLine("start Getdata");
        // Demonstrate that breaking out of a foreach loop releasees the lock
        var t0 = new Thread(() => {
            foreach( var s0 in myList0 )
            {
                Console.WriteLine("List 0 {0}", s0);
                if( s0 == "2" ) break;
            }
        });
        Console.WriteLine("start t0");
        t0.Start();
        t0.Join(); // Acts as 'wait for the thread to complete'
        Console.WriteLine("end t0");
    
        // t1's foreach loop will start (meaning previous t0's lock was cleared
        var t1 = new Thread(() => {
            foreach( var s1 in myList1)
            {
                Console.WriteLine("List 1 {0}", s1);
                // Once another thread will wait on the lock while t1's foreach
                // loop is still active a dead-lock will occure.
                var t2 = new Thread(() => {
                    foreach( var s2 in myList2 )
                    {
                        Console.WriteLine("List 2 {0}", s2);
                    }
                } );
                Console.WriteLine("start t2");          
                t2.Start();
                t2.Join();
                Console.WriteLine("end t2");            
            }
        });
        Console.WriteLine("start t1");
        t1.Start();
        t1.Join();
        Console.WriteLine("end t1");
        Console.WriteLine("end GetData");
    }
    
    void foreachAction( IEnumerable target, Action action )
    {
        foreach( var t in target )
        {
            action(t);
        }
    }
    
    public class DataGetter
    {
        private List _data = new List() { "1", "2", "3", "4", "5" };
    
        public IEnumerable GetData(object lockObj, string listName)
        {
            Console.WriteLine("{0} Starts", listName);
            lock (lockObj)
            {
                Console.WriteLine("{0} Lock Taken", listName);
                foreach (string s in _data)
                {
                    yield return s;
                }
            }
            Console.WriteLine("{0} Lock Released", listName);
        }
    }
    

提交回复
热议问题