Correct way to setting a tag to all cells in TableView

Question

I\'m using a button inside a tableView in which I get the indexPath.row when is pressed. But it only works fine when the cells can be displayed in

Answer 1

You are running into the issue of cell-reuse.

When you create a button for the view you set a tag to it, but then you override this tag to set the row number to it.

When the cell get's reused, because the row number is longer ROW_BUTTON_ACTION, you don't reset the tag to the correct row number and things go wrong.

Using a tag to get information out of a view is almost always a bad idea and is quite brittle, as you can see here.

As Matt has already said, walking the hierarchy is a better idea.

Also, your method doesn't need to be written in this way. If you create your own custom cell, then the code you use to create and add buttons and tags isn't needed, you can do it in a xib, a storyboard, or even in code in the class. Furthermore, if you use the dequeue method that takes the index path, you will always get either a recycled cell, or a newly created cell, so there is no need to check that the cell returned is not nil.