I use Cygwin on Windows, so I use:
export EDITOR="emacs -nw"
The -nw is for no-windows, i.e. tell Emacs not to try and use X Window.
The Emacs keybindings don't work for me from a Windows shell, so I would only use this from a Cygwin shell... (rxvt is recommended.)