What could cause a dynamic_cast to crash?

Question

I have a piece of code looking like this :

TAxis *axis = 0;
if (dynamic_cast(obj))
   axis = (dynamic_cast         


        

Answer 1

I suggest using a different syntax for this code snippet.

if (MonitorObjectH1C* monitorObject = dynamic_cast(obj))
{
    axis = monitorObject->GetXaxis();
}

You can still crash if some other thread is deleting what monitorObject points to or if obj is crazy garbage, but at least your problem isn't casting related anymore and you're not doing the dynamic_cast twice.