“Object required” when using Set in an assignment

后端 未结 3 682
耶瑟儿~
耶瑟儿~ 2020-12-06 16:49
call main()
sub main()
    Dim scmd
    Set scmd = \"c:\\windows\\system32\\cscript.exe //nologo c:\\s.vbs\"
    createobject(\"wscript.shell\").run scmd,0,false
end         


        
3条回答
  •  粉色の甜心
    2020-12-06 17:22

    As

    >> WScript.Echo CreateObject("WScript.Shell").CurrentDirectory
    >>
    E:\trials\SoTrials\answers\trials\AlgoTaBu\SuSo\wsf
    

    proves, there is no rule or law at all that "Your Set scmd should be instantiating the WScript.Shell". Putting the command to execute in string variable scmd (or perhaps better sCmd) and not creating a variable for an only-once-used value are good practices.

    The revised version (minus the stupid Set):

    call main()
    sub main()
        Dim scmd
        scmd = "c:\windows\system32\cscript.exe //nologo c:\s.vbs"
        createobject("wscript.shell").run scmd,0,false
    end sub
    

    will work just as well as Lankymart's version.

    To spell everything out:

    1. The Set keyword, its semantic, and its error message are design flaws, that make VBScript harder to use correctly. "site:stackoverflow.com vbscript "object required" Set" results in 1500 hits. Even if much of those hits do not concern the "Set x = 'non-object' blunder, that's clearly too much. To explain/excuse those IEDs you have to consider that BASIC is a stone age language.
    2. A person learning VBScript is entitled to be surprised by the "Set x = 'non-object' mistake twice. If it happens trice (or more often), he/she should be ashamed (and keep silent about it). Above all that problem should not pollute this site.
    3. When I posted my contribution, all answers/comments - with the exception of Alex K.'s 'Just delete the Set' - emphasized/concentrated on the .Run statement; one answer called the script "topsy curvy", one answer even repeated the atrocity. So I tried to point out that there is exactly one error: The spurious Set.
    4. I failed miserably. Evidence: John Saunders changed the title from "VBScript error" (unspecific but true) to "“Object required” when calling Run on Wscript.Shell" (specific but wrong), Lankymart engaged in psychological/philological research to save the Set at the expense of the string.
    5. My only hope: Everybody reading this will be so disgusted by my harping on the Set, that she/he from now on will think twice when typing:

    wtf

    Set x = "     ---- stop or be damned!!!
    Set x = obj.getNumber() + 4  ---- oh no!!!
    
    1. All to no avail - Same mistake again

提交回复
热议问题