I have designed and developed more than 10 sites, but I still have a doubt about the correct unit I should use. Should it be px, em or %
Different units depending on context. If there was one that was best for every situation, then there wouldn't be so many units.
As rules of thumb go:
If you are working on screen media:
% for font sizespx for imagespx, %, or em for box sizesIf you are working in print media:
px (this is not a hard rule by any means) and everything else is fair game. It really depends how much control you want.