check box in listview not working properly

Question

I am implementing the checkbox with listview for every Iten of listview.The Problem i am getting is when I am clicking on any single check box and when i scroll then some ot

Answer 1

This is happening because of view recycling. What you need to do is maintain an array of say booleans and every time a checkbox is checked toggle the corresponding boolean. Then in your getview check the corresponding boolean array position and set the state of the check box.

Along these lines: I have modified it so it displays correctly. Have not checked what the rest of your code is upto. ^_^

public class CustomListViewAdapter extends ArrayAdapter {

ViewHolder holder = null;
private LayoutInflater inflator = null;
private ArrayList orderList = null;
ArrayList allViews;

boolean[] checkedStates; //********** NEW ********

public CustomListViewAdapter(Context context, int resource,
        List objects) {
    super(context, resource, objects);

    orderList = (ArrayList) objects;
    inflator = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
    allViews = new ArrayList();

    checkedStates = new boolean[objects.size()]; //********** NEW ********
}

@Override   //********** NEW ******** position argument is now final 
public View getView(final int position, View convertView, ViewGroup parent) {
    if(convertView == null) {
        convertView = inflator.inflate(R.layout.listview_add_order, null);
        holder = new ViewHolder();
        convertView.setTag(holder);
        holder.txtViewName = (TextView) convertView.findViewById(R.id.txtViewAddOrder);
        holder.spinnerAddorder = (Spinner) convertView.findViewById(R.id.spinnerAddOrder);
        holder.checkAddorder = (CheckBox) convertView.findViewById(R.id.checkAddOrder);
        holder.checkAddorder.setTag(holder);
    } else {
        holder = (ViewHolder) convertView.getTag();


        holder.checkAddorder.setTag(holder);
    }

    allViews.add(position, holder.spinnerAddorder);

    holder.checkAddorder.setOnClickListener(new OnClickListener() {

        @Override
        public void onClick(View view) {

              checkedStates[position] = !checkedStates[position]; //********** NEW ********
        }
    });

    holder.chechAddorder.setChecked(checkedStates[position]); //********** NEW ********

    List list = new ArrayList();
    list.add("Select Quantity");
    list.add("1");
    list.add("2");
    list.add("3");
    ArrayAdapter dataAdapter = new ArrayAdapter(this.getContext(),R.layout.spinner_add_order_style, list);
    dataAdapter.setDropDownViewResource(android.R.layout.simple_spinner_item);
    holder.spinnerAddorder.setAdapter(dataAdapter);

    if(checkedStates[position]) { //********** NEWEST ******** assuming true is checked and false is unchecked


        ViewHolder checkPosition = (ViewHolder) holder.checkAddorder.getTag();
        checkPosition.spinnerAddorder.setVisibility(View.VISIBLE);
    } else {

        ViewHolder checkPosition = (ViewHolder) holder.checkAddorder.getTag();
        checkPosition.spinnerAddorder.setVisibility(View.INVISIBLE);
    }


    Client order = orderList.get(position);

    holder.txtViewName.setText(order.getFirstName());
    return  convertView;
}

private static class ViewHolder {
    public TextView txtViewName = null;
    public Spinner spinnerAddorder = null;
    public CheckBox checkAddorder = null;
}

     }