More elegant way to check for duplicates in C++ array?

Question

I wrote this code in C++ as part of a uni task where I need to ensure that there are no duplicates within an array:

// Check for duplicate numbers in user in         


        

Answer 1

It's ok, specially for small array lengths. I'd use more efficient aproaches (less than n^2/2 comparisons) if the array is mugh bigger - see DeadMG's answer.

Some small corrections for your code:

• Instead of int j = i writeint j = i +1 and you can omit your if(j != i) test
• You should't need to declare i variable outside the for statement.